BO Allocation Table MultiSelect with Change Role#11264
Open
jacobfelknor wants to merge 1 commit intoinventree:masterfrom
Open
BO Allocation Table MultiSelect with Change Role#11264jacobfelknor wants to merge 1 commit intoinventree:masterfrom
jacobfelknor wants to merge 1 commit intoinventree:masterfrom
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11264 +/- ##
==========================================
- Coverage 88.07% 88.07% -0.01%
==========================================
Files 1290 1290
Lines 58460 58459 -1
Branches 1965 1964 -1
==========================================
- Hits 51487 51486 -1
Misses 6484 6484
Partials 489 489
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multiselect check boxes on the Build Order Allocations table is currently tied to the BO delete role. This PR changes that to the BO modify role.
My justification is that users with change role already can consume allocated stock, but this must currently be done on a one-by-one basis unless they also have the delete role.