Refactor label/report template copying #6582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matmair/issue2585
…matmair/issue2585
…refactor-labels
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
|
@matmair nice work, this will clean things up nicely for our future work |
|
@matmair Does this also fixes the bug that if I change an InvenTree provided template, it gets crated again and I end up with duplicate templates? |
|
@wolflu05 no, it is a pure internal refactor. The behaviour you describe is a more nuanced problem and will have to be discussed as the current way templates are handled (file based) has some problems when interacting with an API. |
|
Ok. Yeah that's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards #5841 and will help with #6478.
It factors out the
ready()function of thereportandlabelapps into a generic function that can also be used by plugins to ship their own default templating content.This does not change the functionality around templating and is only a refactor to get functionality into one place.