Skip to content

[CI] Add zimor to check github action security#8639

Merged
SchrodingersGat merged 14 commits intoinventree:masterfrom
matmair:ci-add-zimor
Dec 16, 2024
Merged

[CI] Add zimor to check github action security#8639
SchrodingersGat merged 14 commits intoinventree:masterfrom
matmair:ci-add-zimor

Conversation

@matmair
Copy link
Contributor

@matmair matmair commented Dec 9, 2024

There have been several attacks in the past through GitHub Actions - often using already-known problems. This adds zimor to find various workflow problems that the OSSF scorecard is not finding. Inspired by python-attrs/attrs#1379

It also cleans up a few things in the actions:

  • correct pinning of hashes
  • reduces duplicate clones (the environment setup action is already containing a clone) -> will be a new PR
  • remove unneeded persistent git credentials

@matmair matmair added CI CI / unit testing ecosystem security Relates to a security issue labels Dec 9, 2024
@matmair matmair added this to the 1.0.0 milestone Dec 9, 2024
@matmair matmair self-assigned this Dec 9, 2024
@netlify
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 7d60a38
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/675f410f3f648b000800296d

@matmair matmair added the full-run Always do a full QC CI run label Dec 9, 2024
@matmair matmair marked this pull request as ready for review December 9, 2024 18:45
@matmair matmair closed this Dec 9, 2024
@matmair matmair reopened this Dec 9, 2024
@matmair matmair marked this pull request as draft December 9, 2024 18:45
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (7bfd36f) to head (7d60a38).
Report is 302 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8639      +/-   ##
==========================================
+ Coverage   84.66%   84.67%   +0.01%     
==========================================
  Files        1195     1195              
  Lines       54363    54363              
  Branches     2057     2057              
==========================================
+ Hits        46027    46034       +7     
- Misses       7823     7824       +1     
+ Partials      513      505       -8     
Flag Coverage Δ
backend 86.08% <ø> (ø)
migrations 42.67% <ø> (+0.02%) ⬆️
pui 69.22% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matmair matmair changed the title [CI] Add zimor to checks [CI] After 0.17.0 Add zimor to check github action security Dec 13, 2024
@matmair matmair marked this pull request as ready for review December 15, 2024 13:07
@matmair matmair closed this Dec 15, 2024
@matmair matmair reopened this Dec 15, 2024
@matmair matmair changed the title [CI] After 0.17.0 Add zimor to check github action security [CI] Add zimor to check github action security Dec 16, 2024
@SchrodingersGat SchrodingersGat merged commit 9dc4fc1 into inventree:master Dec 16, 2024
45 checks passed
@SchrodingersGat SchrodingersGat deleted the ci-add-zimor branch December 16, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI / unit testing ecosystem full-run Always do a full QC CI run security Relates to a security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants