-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker] Alpine image fix #9118
[Docker] Alpine image fix #9118
Conversation
- No longer needed as we are using python 3.11
Also fixes some docker warnings from the alpine Dockerfile
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9118 +/- ##
==========================================
+ Coverage 86.07% 86.08% +0.01%
==========================================
Files 1177 1176 -1
Lines 51927 51897 -30
Branches 2120 2120
==========================================
- Hits 44696 44677 -19
+ Misses 6689 6682 -7
+ Partials 542 538 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thank you for tackling this- segfaults are to low on the stack for me
Replaces #9114
It appears that the base docker image
python:3.11-alpine3.21
has some issues with segfaulting (see issues referenced below)Thus, reverting back to
python:3.11-alpine3.20
which does not appear to have this issue.The caveat is that this image only supports postgres:16 - the limitations around this are now referenced more clearly in the documentation.
Note: I have run the failing test (referenced in #9114) multiple times on this new setup, without issue.
References