Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Alpine image fix #9118

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Feb 21, 2025

Replaces #9114

It appears that the base docker image python:3.11-alpine3.21 has some issues with segfaulting (see issues referenced below)

Thus, reverting back to python:3.11-alpine3.20 which does not appear to have this issue.

The caveat is that this image only supports postgres:16 - the limitations around this are now referenced more clearly in the documentation.

Note: I have run the failing test (referenced in #9114) multiple times on this new setup, without issue.

References

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed dependency Relates to a project dependency docker Docker / docker-compose labels Feb 21, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 7d43057
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67b8074812e5ae0008415eef

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (19f772b) to head (7d43057).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9118      +/-   ##
==========================================
+ Coverage   86.07%   86.08%   +0.01%     
==========================================
  Files        1177     1176       -1     
  Lines       51927    51897      -30     
  Branches     2120     2120              
==========================================
- Hits        44696    44677      -19     
+ Misses       6689     6682       -7     
+ Partials      542      538       -4     
Flag Coverage Δ
backend 88.08% <ø> (+0.01%) ⬆️
migrations 42.91% <ø> (-0.11%) ⬇️
pui 68.99% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thank you for tackling this- segfaults are to low on the stack for me

@SchrodingersGat SchrodingersGat merged commit 15ad624 into inventree:master Feb 21, 2025
32 checks passed
@SchrodingersGat SchrodingersGat deleted the alpine-image-fix branch February 21, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed dependency Relates to a project dependency docker Docker / docker-compose full-run Always do a full QC CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants