Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: need for hard coded token #9136

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

matmair
Copy link
Member

@matmair matmair commented Feb 21, 2025

codecov supports github OIDC for uplad so we can remove the hard-coded token

@matmair matmair added the CI CI / unit testing ecosystem label Feb 21, 2025
@matmair matmair added this to the 1.0.0 milestone Feb 21, 2025
@matmair matmair self-assigned this Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 581852e
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67bcd6438dc301000810464e
😎 Deploy Preview https://deploy-preview-9136--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (991b578) to head (581852e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9136      +/-   ##
==========================================
+ Coverage   85.96%   86.13%   +0.16%     
==========================================
  Files        1181     1180       -1     
  Lines       52209    52105     -104     
  Branches     2184     2184              
==========================================
- Hits        44884    44882       -2     
+ Misses       6767     6666     -101     
+ Partials      558      557       -1     
Flag Coverage Δ
backend 88.11% <ø> (+<0.01%) ⬆️
migrations 42.95% <ø> (+<0.01%) ⬆️
pui 69.57% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair added the full-run Always do a full QC CI run label Feb 22, 2025
@matmair matmair marked this pull request as ready for review February 24, 2025 20:28
@matmair
Copy link
Member Author

matmair commented Feb 24, 2025

@SchrodingersGat after merging this we can remove the secret CODECOV_TOKEN

@SchrodingersGat SchrodingersGat merged commit 9f236f5 into inventree:master Feb 24, 2025
28 checks passed
@SchrodingersGat SchrodingersGat deleted the chore-remove-need-for-token branch February 24, 2025 22:22
@matmair matmair restored the chore-remove-need-for-token branch February 25, 2025 09:42
matmair added a commit that referenced this pull request Feb 25, 2025
matmair added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem full-run Always do a full QC CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants