Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin cleanup #9142

Merged
merged 4 commits into from
Feb 22, 2025
Merged

Conversation

SchrodingersGat
Copy link
Member

Removes references to the defunct "SettingsContentMixin" plugin class.

This is not used anywhere any more. But, any plugins which call this will need to be adjusted.

@SchrodingersGat SchrodingersGat added plugin Plugin ecosystem breaking Indicates a major update or change which breaks compatibility refactor labels Feb 22, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Feb 22, 2025
Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit b55a3dd
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67b966bd632dd70008a54cf6

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (44cca7d) to head (b55a3dd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9142      +/-   ##
==========================================
- Coverage   86.09%   86.07%   -0.02%     
==========================================
  Files        1178     1179       +1     
  Lines       52048    52079      +31     
  Branches     2171     2171              
==========================================
+ Hits        44810    44829      +19     
- Misses       6679     6691      +12     
  Partials      559      559              
Flag Coverage Δ
backend 88.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 74e3122 into inventree:master Feb 22, 2025
27 checks passed
@SchrodingersGat SchrodingersGat deleted the mixin-cleanup branch February 22, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a major update or change which breaks compatibility plugin Plugin ecosystem refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant