Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Settings render #9148

Merged
merged 4 commits into from
Feb 22, 2025
Merged

Conversation

SchrodingersGat
Copy link
Member

Allow native instance rendering of settings which point to database models.

Additionally, add some more playwright tests for plugins and settings.

@SchrodingersGat SchrodingersGat added CI CI / unit testing ecosystem User Interface Related to the frontend / User Interface labels Feb 22, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Feb 22, 2025
Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit b967460
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67b99bfb7922a000088be602
😎 Deploy Preview https://deploy-preview-9148--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.13%. Comparing base (bd7e515) to head (b967460).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...c/frontend/src/components/settings/SettingItem.tsx 25.00% 13 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9148      +/-   ##
==========================================
+ Coverage   86.05%   86.13%   +0.07%     
==========================================
  Files        1180     1181       +1     
  Lines       52083    52142      +59     
  Branches     2171     2182      +11     
==========================================
+ Hits        44820    44910      +90     
+ Misses       6703     6673      -30     
+ Partials      560      559       -1     
Flag Coverage Δ
backend 88.11% <ø> (+<0.01%) ⬆️
pui 69.62% <25.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 8df34ce into inventree:master Feb 22, 2025
29 checks passed
@SchrodingersGat SchrodingersGat deleted the settings-render branch February 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants