Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom hosted dependency #288

Merged
merged 10 commits into from
Feb 27, 2025
Merged

Conversation

MobiliteDev
Copy link
Contributor

Copy link

vercel bot commented Oct 25, 2024

@chedwin41 is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

docs-page bot commented Oct 25, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/dart_custom_lint~288

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

@rrousselGit
Copy link
Collaborator

Could you add tests for this?

@MobiliteDev
Copy link
Contributor Author

Could you add tests for this?

I'm having trouble getting the tests to pass. Only 35 out of 75 are passing, even on the master branch, so I think I might be doing something wrong.

That said, I've added one test for my case. Let me know if this is sufficient for you.

@rrousselGit
Copy link
Collaborator

I'm having trouble getting the tests to pass. Only 35 out of 75 are passing, even on the master branch, so I think I might be doing something wrong.

Tests are passing on master. Make sure your SDK is up-to-date

@rrousselGit
Copy link
Collaborator

You had a print in your code. That likely caused many tests to fail, as various tests check stdout.

@MobiliteDev
Copy link
Contributor Author

Thanks for removing the print.

I still can't manage to make the tests work, i'm using the main version of dart :
image

But if it runs well here the issue is only on my side so no big deal.

@rrousselGit
Copy link
Collaborator

Note that your test is failing :)

@MobiliteDev
Copy link
Contributor Author

Hi,

I wanted to kindly follow up on this. It seems ready to go. Would it be possible to review and merge if everything looks good?

Thank you for your time and for all the great work on this project! 😊

@Tristan-gu
Copy link

Hi @rrousselGit ,

when do you think you will merge this please ?

@thomas-stockx
Copy link

Is this still being looked at? Any way we can help push this forward?

@rrousselGit rrousselGit merged commit d247b3e into invertase:main Feb 27, 2025
4 of 5 checks passed
Artur-Wisniewski pushed a commit to Artur-Wisniewski/dart_custom_lint that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants