Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relax android package name validation #369

Merged

Conversation

tenhobi
Copy link
Contributor

@tenhobi tenhobi commented Jan 27, 2025

Fixes #368

Description

Relax conditions for android package name validations

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Jan 27, 2025
@tenhobi tenhobi changed the title Relax package name validation fix: Relax android package name validation Jan 27, 2025
@russellwheatley
Copy link
Member

@tenhobi - nice! Didn't realise you'd created a PR.

I ran unit tests locally as CI will fail with forks:

4 packages have newer versions incompatible with dependency constraints.
Try `dart pub outdated` for more information.
00:00 +0: loading test/unit_test.dart
00:00 +0: test/unit_test.dart: Apple App Bundle ID Validator Valid bundle IDs
00:00 +1: test/unit_test.dart: Apple App Bundle ID Validator Invalid bundle IDs
00:00 +2: test/unit_test.dart: Android Package Name Validator Valid Package names
00:00 +3: test/unit_test.dart: Android Package Name Validator Invalid Package names
00:00 +4: test/unit_test.dart: Firebase CLI JSON response parser function `firebaseCLIJsonParse()` Valid JSON response from Firebase CLI
00:00 +5: test/unit_test.dart: Firebase CLI JSON response parser function `firebaseCLIJsonParse()` Invalid JSON response from Firebase CLI
00:00 +6: All tests passed!
flutterfire_cli: SUCCESS
---------------------------------------------------------------------------------------------------------------------------------------

$ melos exec
  └> dart pub get && dart run test --reporter expanded
     └> SUCCESS

melos run test
  └> melos exec --ignore="flutterfire_starter_hooks" --concurrency=1 -- "dart pub get && dart run test --reporter expanded"
     └> SUCCESS

@russellwheatley russellwheatley merged commit e990364 into invertase:main Jan 30, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention OP created or responded to issue and it needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: unnecessary android package name validation
3 participants