Skip to content

build(deps): updating JDK/node/actions/JS deps/native deps #8482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 25, 2025

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Apr 21, 2025

Description

Periodic maintenance

Related issues

none logged - it's our local infrastructure

Release Summary

semantic release commits, none of which should trigger a release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

CI will exercise everything, but also local test runs


Think react-native-firebase is great? Please consider supporting the project with any of the below:

eliminates repetition in iOS build now that it is a matrix,
other platform only used them once but best to follow same pattern
as ios build
Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 0:20am

@mikehardy
Copy link
Collaborator Author

mikehardy commented Apr 21, 2025

Digging into coverage issue, at least for android, it appears the native coverage and the javascript coverage were both empty for some reason, from the downloaded coverage report on codecov https://app.codecov.io/github/invertase/react-native-firebase/commit/08d58f67c73c715e134a2b29e5c91194a09626c3


<<<<<< network

# path=/home/runner/work/react-native-firebase/react-native-firebase/tests/android/app/build/reports/jacoco/jacocoAndroidTestReport/jacocoAndroidTestReport.xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.1//EN" "report.dtd"><report name="app"/>
<<<<<< EOF

# path=/home/runner/work/react-native-firebase/react-native-firebase/coverage/lcov.info

<<<<<< EOF

This seems to happen on quite a lot of our pull requests though, yet we still have good coverage on main most of the time.
Not sure exactly what's going on here but it seems flaky vs permanently busted

Copy link
Collaborator

@MichaelVerdon MichaelVerdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, surely we can make a script to make this task less laborious like I made on FlutterFire? What do you think?

@mikehardy
Copy link
Collaborator Author

@MichaelVerdon I'm still working through it - re: script, hard to say. I mean, I love a script (witness make-demo.sh and I've got piles of others). But before this is done, it's going to involve upgrades of deps in these ecosystems:

  • github actions (dependabot helps, but we still have to do it)
  • javascript deps (and there are breaking changes all over, the non-breaking ones are scriptable but also take effectively no time)
  • react-native (need to forward port things every time)
  • native java items (check + forward port things)
  • the node and jdk and github runner versions used in CI (trivial to do, the time taken is all checking logs to make sure things work)

So things could be automated a bit but there would be an automation cost and maintenance cost for it, while I think the real cost of the activity is in verification and forward-porting

I don't think the speedup is that significant but the smaller runner
should be more cost-efficient

Note that public Ubuntu runner is tight on space, so add a space liberation step
previously it was a specific node command
firebase changed entry points in package.json and it messes up
jest tests until handled
- not 0.79 yet as react-native-macos 0.79+ isn't out yet
- react-native and react-native-macos drop patch hunks as they are upstreamed now
gradle 10 will remove space-assignment, so we need to forward port

note that the Invertase gradle plugin still uses space assignment,
so this work is not complete yet
this surfaces a bunch of deprecation warnings which will need attention
- react-native-builder-bob no longer accepts an `esm` property for typescript target
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 21419a8 to ca40fb3 Compare April 25, 2025 00:17
@mikehardy mikehardy merged commit 86bdd25 into main Apr 25, 2025
17 of 18 checks passed
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch April 25, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants