-
Notifications
You must be signed in to change notification settings - Fork 2.2k
build(deps): updating JDK/node/actions/JS deps/native deps #8482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eliminates repetition in iOS build now that it is a matrix, other platform only used them once but best to follow same pattern as ios build
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Digging into coverage issue, at least for android, it appears the native coverage and the javascript coverage were both empty for some reason, from the downloaded coverage report on codecov https://app.codecov.io/github/invertase/react-native-firebase/commit/08d58f67c73c715e134a2b29e5c91194a09626c3
This seems to happen on quite a lot of our pull requests though, yet we still have good coverage on main most of the time. |
74424a7
to
a980d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, surely we can make a script to make this task less laborious like I made on FlutterFire? What do you think?
@MichaelVerdon I'm still working through it - re: script, hard to say. I mean, I love a script (witness make-demo.sh and I've got piles of others). But before this is done, it's going to involve upgrades of deps in these ecosystems:
So things could be automated a bit but there would be an automation cost and maintenance cost for it, while I think the real cost of the activity is in verification and forward-porting |
0e67533
to
49cbae4
Compare
49cbae4
to
e89f227
Compare
e89f227
to
7217aab
Compare
7217aab
to
1f1d705
Compare
1f1d705
to
637bc8a
Compare
637bc8a
to
21419a8
Compare
I don't think the speedup is that significant but the smaller runner should be more cost-efficient Note that public Ubuntu runner is tight on space, so add a space liberation step
previously it was a specific node command
firebase changed entry points in package.json and it messes up jest tests until handled
- not 0.79 yet as react-native-macos 0.79+ isn't out yet - react-native and react-native-macos drop patch hunks as they are upstreamed now
gradle 10 will remove space-assignment, so we need to forward port note that the Invertase gradle plugin still uses space assignment, so this work is not complete yet
this surfaces a bunch of deprecation warnings which will need attention
- react-native-builder-bob no longer accepts an `esm` property for typescript target
21419a8
to
ca40fb3
Compare
Description
Periodic maintenance
Related issues
none logged - it's our local infrastructure
Release Summary
semantic release commits, none of which should trigger a release
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
CI will exercise everything, but also local test runs
ccache behavior needs verification after moving env vars, I have looked at the detailed CI run logs and I see cache misses but that's expected at the moment - it is caching things though, which is good
Vercel settings were updated to build with node22 at the same time, the preview will show whether it worked or not (check reference API for typedoc generation as well) https://react-native-firebase-6mtkf83zt-invertase.vercel.app/
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter