fix: database query with subscribe never fetches#77
Open
mbergal wants to merge 2 commits intoinvertase:dev-releasefrom
Open
fix: database query with subscribe never fetches#77mbergal wants to merge 2 commits intoinvertase:dev-releasefrom
mbergal wants to merge 2 commits intoinvertase:dev-releasefrom
Conversation
|
|
| eventCount[subscriptionHash] ??= 0; | ||
| eventCount[subscriptionHash]++; | ||
| if (eventCount[subscriptionHash] === 1) { | ||
| resolvePromise(data || null); |
There was a problem hiding this comment.
Suggested change
| resolvePromise(data || null); | |
| resolvePromise(data ?? null); |
Otherwise, if data === false you get back null and you never get the actual value of the data. 🤦🏼♂️
I spent hours trying to figure out why my DB value of false kept coming back null.
|
@mbergal Do you mind signing the CLA please? A lot of peeps are waiting on this fix it looks like 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #73