chore: add info for scanOrientation on apps targeting Android 16 in tablets #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgerardojacinto
requested review from
OS-pedrogustavobilro,
OS-ruimoreiramendes,
andredestro,
jcesarmobile,
markemer and
theproducer
eric-horodyski
approved these changes
Nov 24, 2025
markemer
approved these changes
Nov 24, 2025
Contributor
|
I fixed the lint error, but the CI fails later, which would get fixed with Capacitor 8 support (out-of-scope for this PR). So I guess this can be merged? |
OS-pedrogustavobilro
approved these changes
Nov 25, 2025
jcesarmobile
requested changes
Nov 25, 2025
Member
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
The text should look like the one on screen-orientation plugin, explaining the opt-out for Android 16 devices
https://github.com/ionic-team/capacitor-plugins/blob/main/screen-orientation/src/definitions.ts#L35-L39
…c-team/capacitor-barcode-scanner into chore/RMET-4400/update-barcode-docs # Conflicts: # plugin/src/definitions.ts
Collaborator
Author
|
@jcesarmobile updated the text accordingly, can you check? |
jcesarmobile
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.