Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ jobs:
with:
path: ~/.npm
key: ${{ runner.OS }}-dependency-cache-${{ hashFiles('**/package.json') }}
- run: npm install
- run: npm install --legacy-peer-deps
- run: npm run build
6 changes: 3 additions & 3 deletions ios/App/App.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,12 @@
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = 9YN2HU59K8;
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
IPHONEOS_DEPLOYMENT_TARGET = 15.6;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = com.capacitorjs.app.testapp;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
};
Expand All @@ -381,7 +381,7 @@
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = 9YN2HU59K8;
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
IPHONEOS_DEPLOYMENT_TARGET = 15.6;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.capacitorjs.app.testapp;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
2 changes: 1 addition & 1 deletion ios/App/Podfile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly missing some updates on Android, like compile/targetSdk; at least when compared with your PR for Cap 7 - https://github.com/ionic-team/capacitor-testapp/pull/664/files

Although that one was for stable versions, I imagine some of the updates are still relevant.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative '../../node_modules/@capacitor/ios/scripts/pods_helpers'

platform :ios, '14.0'
platform :ios, '15.0'
use_frameworks!

# workaround to avoid Xcode caching of Pods that requires
Expand Down
10 changes: 5 additions & 5 deletions ios/App/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- Capacitor (7.2.0):
- Capacitor (8.0.0-alpha.2):
- CapacitorCordova
- CapacitorActionSheet (7.0.1):
- Capacitor
Expand All @@ -13,7 +13,7 @@ PODS:
- Capacitor
- CapacitorClipboard (7.0.1):
- Capacitor
- CapacitorCordova (7.2.0)
- CapacitorCordova (8.0.0-alpha.2)
- CapacitorDevice (7.0.1):
- Capacitor
- CapacitorDialog (7.0.1):
Expand Down Expand Up @@ -203,14 +203,14 @@ EXTERNAL SOURCES:
:path: "../../node_modules/@capacitor/toast"

SPEC CHECKSUMS:
Capacitor: 03bc7cbdde6a629a8b910a9d7d78c3cc7ed09ea7
Capacitor: 82af0e75f93d8d6260b780c0b6fb6d98dd7244d4
CapacitorActionSheet: 4213427449132ae4135674d93010cb011725647e
CapacitorApp: febecbb9582cb353aed037e18ec765141f880fe9
CapacitorAppLauncher: bab4ca931a308252d2bafcb78ca6a364bd1d4c4e
CapacitorBrowser: 6299776d496e968505464884d565992faa20444a
CapacitorCamera: 6e73f1fc6c629a672658705a02409b60854bc0f1
CapacitorClipboard: 70bfdb42b877b320a6e511ab94fa7a6a55d57ecb
CapacitorCordova: 5967b9ba03915ef1d585469d6e31f31dc49be96f
CapacitorCordova: 9b60d7dd7f5035cefe9b5f7f3edf11ccd93b6ae6
CapacitorDevice: c6f6d587dd310527f8a48bf09c4e7b4a4cf14329
CapacitorDialog: 0e09f242f6c3f5e82e4dc76b20f2a056be57a579
CapacitorFilesystem: e6261c410436f54908c11f94336c5b58286b1db0
Expand Down Expand Up @@ -239,6 +239,6 @@ SPEC CHECKSUMS:
nanopb: fad817b59e0457d11a5dfbde799381cd727c1275
PromisesObjC: f5707f49cb48b9636751c5b2e7d227e43fba9f47

PODFILE CHECKSUM: 40c4376da4317650e2f6f87769fbedbfce4a645e
PODFILE CHECKSUM: e0490ba851f21ebb661b2309d2ae788818c752b4

COCOAPODS: 1.16.2
108 changes: 46 additions & 62 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

56 changes: 28 additions & 28 deletions package.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have alphas/next versions for the plugins using Capacitor 8. I don't know historically how has it been in the past, if plugin alphas should be released together with Capacitor 8, and any issues are fixed after the fact, or would it be first Capacitor then fix any issues with new Capacitor version and only after release alphas?

Original file line number Diff line number Diff line change
Expand Up @@ -25,33 +25,33 @@
]
},
"dependencies": {
"@capacitor/action-sheet": "^7.0.0",
"@capacitor/android": "^7.0.0",
"@capacitor/app": "^7.0.0",
"@capacitor/app-launcher": "^7.0.0",
"@capacitor/browser": "^7.0.0",
"@capacitor/camera": "^7.0.0",
"@capacitor/clipboard": "^7.0.0",
"@capacitor/core": "^7.0.1",
"@capacitor/device": "^7.0.0",
"@capacitor/dialog": "^7.0.0",
"@capacitor/filesystem": "^7.0.0",
"@capacitor/geolocation": "^7.0.0",
"@capacitor/haptics": "^7.0.0",
"@capacitor/ios": "^7.0.1",
"@capacitor/keyboard": "^7.0.0",
"@capacitor/local-notifications": "^7.0.0",
"@capacitor/motion": "^7.0.0",
"@capacitor/network": "^7.0.0",
"@capacitor/preferences": "^7.0.0",
"@capacitor/push-notifications": "^7.0.0",
"@capacitor/screen-orientation": "^7.0.0",
"@capacitor/screen-reader": "^7.0.0",
"@capacitor/share": "^7.0.0",
"@capacitor/splash-screen": "^7.0.0",
"@capacitor/status-bar": "^7.0.0",
"@capacitor/text-zoom": "^7.0.0",
"@capacitor/toast": "^7.0.0",
"@capacitor/action-sheet": "next",
"@capacitor/android": "8.0.0-alpha.2",
"@capacitor/app": "next",
"@capacitor/app-launcher": "next",
"@capacitor/browser": "next",
"@capacitor/camera": "next",
"@capacitor/clipboard": "next",
"@capacitor/core": "8.0.0-alpha.2",
"@capacitor/device": "next",
"@capacitor/dialog": "next",
"@capacitor/filesystem": "next",
"@capacitor/geolocation": "next",
"@capacitor/haptics": "next",
"@capacitor/ios": "8.0.0-alpha.2",
"@capacitor/keyboard": "next",
"@capacitor/local-notifications": "next",
"@capacitor/motion": "next",
"@capacitor/network": "next",
"@capacitor/preferences": "next",
"@capacitor/push-notifications": "next",
"@capacitor/screen-orientation": "next",
"@capacitor/screen-reader": "next",
"@capacitor/share": "next",
"@capacitor/splash-screen": "next",
"@capacitor/status-bar": "next",
"@capacitor/text-zoom": "next",
"@capacitor/toast": "next",
"@ionic/pwa-elements": "^3.1.1",
"@ionic/react": "^7.0.0",
"@ionic/react-router": "^7.0.0",
Expand All @@ -68,7 +68,7 @@
"react-router-dom": "^5.3.4"
},
"devDependencies": {
"@capacitor/cli": "^7.0.1",
"@capacitor/cli": "8.0.0-alpha.2",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^14.0.0",
"@testing-library/user-event": "^14.4.3",
Expand Down