Skip to content

feat(ios): return secure cookies on local scheme #7733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

feat(ios): return secure cookies on local scheme #7733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ios/Capacitor/Capacitor/Plugins/CapacitorCookieManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,16 @@ public class CapacitorCookieManager {
}

public func getServerUrl() -> URL? {
return self.config?.serverURL ?? self.config?.localURL
guard let serverURL = self.config?.serverURL ?? self.config?.localURL else { return nil }
let assetHandlerScheme = self.config?.localURL.scheme ?? InstanceDescriptorDefaults.scheme
// If we're serving assets bundled with the app, then we need to change the scheme of the URL to
// https so that cookies marked secure are returned from HTTPCookieStorage.
if serverURL.scheme == assetHandlerScheme {
var components = URLComponents(url: serverURL, resolvingAgainstBaseURL: false)
components?.scheme = "https"
return components?.url
}
return serverURL
}

private func isUrlSanitized(_ urlString: String) -> Bool {
Expand Down