fix: Upload progress contentLength
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For progress notifications to work
To avoid this error showing up on XCode logs - The request of a upload task should not contain a body or a body stream, use upload(for:fromFile:), upload(for:from:), or supply the body stream through the urlSession(_:needNewBodyStreamForTask:) delegate method.
alexgerardojacinto
approved these changes
Aug 25, 2025
Contributor
Author
|
Apologies, turns out the capacitor example app wasn't working to test the issue - PR was opened to fix that ionic-team/capacitor-file-transfer#19 |
OS-ruimoreiramendes
approved these changes
Aug 25, 2025
andredestro
approved these changes
Aug 25, 2025
alexgerardojacinto
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses ionic-team/capacitor-file-transfer#10
The upload delegate was receiving -1 for
totalBytesExpectedToSend. According to the apple docs , there's a few ways in which we can do this, opted going with adding the "Content-Length" header - which was done in the old cordova plugin.Furthermore, I noticed this error in logs in XCode when
chunkedModeis true:Which I also fixed in this PR by providing the input stream via the upload delegate instead of directly in the request object.
Type of changes
Tests
You may generate a xcframework using the
scripts/build_framework.shand test in the Capacitor Example app - https://github.com/ionic-team/capacitor-file-transferChecklist