-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(checkbox): improve states and colors #30559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- update scss to use vars; - add more examples to states page;
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a requested change around the errorText. Also, I'm concerned that you changed colors in states and didn't need to do a screenshot update. Maybe we should add visual regression tests for these states, too?
- fix error-text color; - rollback hintText logic;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for adding the new visual regression tests! Just one more thing I noticed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information
basic
indeterminate
Bottom Content
States