Skip to content

fix(checkbox): improve states and colors #30559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2025
Merged

fix(checkbox): improve states and colors #30559

merged 8 commits into from
Jul 22, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Jul 18, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • update scss to use vars;
  • add more examples to states page;
  • now the invalid state is only possible for unchecked checkboxes;

Does this introduce a breaking change?

  • Yes
  • No

Other information

basic
indeterminate
Bottom Content
States

@JoaoFerreira-FrontEnd
- errorText and state only appears when checkbox is unchecked;
e097720 
- update scss to use vars;
- add more examples to states page;
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 4:50pm

@github-actions github-actions bot added the package: core @ionic/core package label Jul 18, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd marked this pull request as ready for review July 18, 2025 12:18
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner July 18, 2025 12:18
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd self-assigned this Jul 18, 2025
ShaneK
ShaneK requested changes Jul 18, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a requested change around the errorText. Also, I'm concerned that you changed colors in states and didn't need to do a screenshot update. Maybe we should add visual regression tests for these states, too?

@JoaoFerreira-FrontEnd
- remove invalid rule;
25a9464 
- fix error-text color;
- rollback hintText logic;
ShaneK
ShaneK requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for adding the new visual regression tests! Just one more thing I noticed

ShaneK
ShaneK approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work!

brandyscarney
brandyscarney approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 7f904d0 into next Jul 22, 2025
108 of 116 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-12073 branch July 22, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneK ShaneK ShaneK approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd

Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoaoFerreira-FrontEnd @ShaneK @brandyscarney @Ionitron