use cloudfare cdn instead of unpkg #782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and apologies for the delay! We are going to use jsdelivr to align with Ionic Framework instead. I've given you co-author credit on the linked PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR comes after this issue on stackoverflow: https://stackoverflow.com/questions/58652885/how-do-i-fix-cors-issue-when-using-ionicons-from-cdn/60263752#60263752
which's I faced myself on my company, it turns now unpkg injects redirects on their CDN makes the browser detect cross-origin errors and block loading the files.
so I recommend use cloudfare instead.