Skip to content

Commit

Permalink
chore: remove volta
Browse files Browse the repository at this point in the history
  • Loading branch information
sean-perkins committed May 14, 2024
1 parent da26554 commit 9977b93
Show file tree
Hide file tree
Showing 14 changed files with 12 additions and 41 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/actions/publish-npm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
version: 8
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version-file: './package.json'
node-version: '20.10.0'
cache: 'pnpm'
- name: Install Dependencies
run: pnpm --filter ${{ inputs.scope }} install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Use Node
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version-file: './package.json'
node-version: '20.10.0'
cache: 'pnpm'

- name: Install Dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
version: 8
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version-file: './package.json'
node-version: '20.10.0'
cache: 'pnpm'
- name: Install Dependencies
run: pnpm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Use Node
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version-file: './package.json'
node-version: '20.10.0'
cache: 'pnpm'

- name: Install Dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/prod-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
version: 8
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version-file: './package.json'
node-version: '20.10.0'
cache: 'pnpm'
- name: Install Dependencies
run: pnpm install
Expand All @@ -68,9 +68,9 @@ jobs:
version: ${{ inputs.version }} # "patch", "minor", "major", "prepatch", "preminor", "premajor", "prerelease"
tag: ${{ inputs.tag }} # "latest" or "next"
preid: ${{ inputs.preid }} # Only needed when version is "prepatch", "preminor", "premajor", or "prerelease"
scope: "@stencil/${{ inputs.package }}-output-target"
scope: '@stencil/${{ inputs.package }}-output-target'
# Look at package.json's name
# Coupled to project structure. Update this when adding a new output target.
# Examples: vue-output-target, angular-output-target, react-output-target
working-directory: "./packages/${{ inputs.package }}-output-target" # Follow the repo structure
working-directory: './packages/${{ inputs.package }}-output-target' # Follow the repo structure
token: ${{ secrets.NPM_TOKEN }} # Private, accessible by team leads
8 changes: 2 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,9 @@ This project uses [Prettier](https://prettier.io/) for code formatting. You can
pnpm prettier
```

### Node Versions
### Node.js Versions

This project uses [Volta](https://volta.sh/) to automatically manage what pnpm and node versions are used when developing.

pnpm support in Volta is currently experimental, and requires [Volta v1.1.1](https://github.com/volta-cli/volta/releases/tag/v1.1.1) or higher. Once Volta is installed, follow [this guide](https://docs.volta.sh/advanced/pnpm) for enabling pnpm support in Volta.

If you don't use Volta, don't worry about it... just check the root `package.json` for what version of node and pnpm is currently being used.
This project requires Node.js v20.10.0 or higher.

## Deploying

Expand Down
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,5 @@
"semver": "^5.5.0",
"ts-jest": "^26.2.0"
},
"prettier": "@ionic/prettier-config",
"volta": {
"node": "20.10.0",
"pnpm": "9.0.0"
}
"prettier": "@ionic/prettier-config"
}
5 changes: 1 addition & 4 deletions packages/angular-output-target/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,5 @@
],
"testURL": "http://localhost"
},
"gitHead": "a3588e905186a0e86e7f88418fd5b2f9531b55e0",
"volta": {
"extends": "../../package.json"
}
"gitHead": "a3588e905186a0e86e7f88418fd5b2f9531b55e0"
}
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,5 @@
"setupFilesAfterEnv": [
"<rootDir>/src/setupJest.ts"
]
},
"volta": {
"extends": "../../package.json"
}
}
3 changes: 0 additions & 3 deletions packages/example-project/component-library-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,5 @@
"typescript": "^5.4.5",
"vite": "^5.2.0",
"wdio-vite-service": "^1.0.6"
},
"volta": {
"extends": "../../package.json"
}
}
3 changes: 0 additions & 3 deletions packages/example-project/component-library-vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,5 @@
}
}
}
},
"volta": {
"extends": "../../package.json"
}
}
3 changes: 0 additions & 3 deletions packages/example-project/component-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,5 @@
"@stencil/vue-output-target": "workspace:*",
"@types/puppeteer": "2.0.1",
"jest-cli": "26.0.1"
},
"volta": {
"extends": "../../../package.json"
}
}
3 changes: 0 additions & 3 deletions packages/react-output-target/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@
"vitest": "^1.4.0"
},
"gitHead": "a3588e905186a0e86e7f88418fd5b2f9531b55e0",
"volta": {
"extends": "../../package.json"
},
"dependencies": {
"@lit/react": "^1.0.4",
"ts-morph": "^22.0.0"
Expand Down
5 changes: 1 addition & 4 deletions packages/vue-output-target/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,5 @@
],
"testURL": "http://localhost"
},
"gitHead": "a3588e905186a0e86e7f88418fd5b2f9531b55e0",
"volta": {
"extends": "../../package.json"
}
"gitHead": "a3588e905186a0e86e7f88418fd5b2f9531b55e0"
}

0 comments on commit 9977b93

Please sign in to comment.