Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix dev builds #396

Merged
merged 3 commits into from
Oct 26, 2023
Merged

chore(ci): fix dev builds #396

merged 3 commits into from
Oct 26, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 26, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In 97b1d3c, we changed lerna.json to independently version these packages, so instead of getting a version such as "1.2.3" the script now receives "independent". This caused this script to start returning null. This is not a valid version, so Lerna failed when trying to set the package version.

What is the new behavior?

  • Dev builds now use "0.0.1" as the version

Does this introduce a breaking change?

  • Yes
  • No

Other information

Example test run: https://github.com/ionic-team/stencil-ds-output-targets/actions/runs/6657401774

@liamdebeasi liamdebeasi enabled auto-merge (squash) October 26, 2023 17:02
@liamdebeasi liamdebeasi disabled auto-merge October 26, 2023 17:02
@liamdebeasi liamdebeasi enabled auto-merge (squash) October 26, 2023 17:07
Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward enough!

@liamdebeasi liamdebeasi merged commit cddd8f8 into main Oct 26, 2023
@liamdebeasi liamdebeasi deleted the dev-build-version branch October 26, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants