feat(react-output-target): add customElementsDir configuration option

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally for affected output targets
• Tests (npm test) were run locally and passed
• Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Environments using absolute paths run into issues with using the calculated path for the custom elements directory based on the dist-custom-elements configuration.

Issue URL: Resolves #457

What is the new behavior?

• Re-adds the customElementsDir configuration for developers to manually override the path as needed in their environment.

Does this introduce a breaking change?

• Yes
• No

Other information

Dev-build: @stencil/[email protected]

[dgonzalezr]

I just tested the dev-build on the same repo as the original issue, and I can confirm that it is now working as expected with the customElementsDir configuration option.

[mjsorribas]

Hi! Can you please add documentation about the implementation in the stencil configuration file?
I have something like this :
outputTargets: [
reactOutputTarget({
stencilPackageName: "@mypackage/my-lib-components",
outDir: "../my-lib-components-react/src/",
customElementsDir: "@mypackage/my-lib-components"
}),
I am not clear about whether this is the correct configuration.
Thanks!

notes:
The version 0.6.0 and 0.7.0 generate a break in the build.

The version 0.6.0 generate a folder called undefined and this one contains a components.d.ts.

The version 0.7.0 not permit build properly the library:
[ ERROR ] Error: The 'react-output-target' requires the 'dist-custom-elements'
output target to have 'externalRuntime: false' set in its
configuration. at Object.validate
(mylib-project/node_modules/@stencil/react-output-target/dist/react-output-target.cjs:37:1647)

The only version that works properly is release 0.5.3.
I used the latest stencil package 4.21.0.

[christian-bromann]

The version 0.6.0 and 0.7.0 generate a break in the build.

Our team currently doesn't apply strict semver on these output targets as we haven't released a v1.0 just yet.

We have recently updated the docs around the React Output Target. Mind taking a look and help us identify what is missing?

[christian-bromann]

[ ERROR ] Error: The 'react-output-target' requires the 'dist-custom-elements'
output target to have 'externalRuntime: false' set in its

We recommend this setup when integrating your Stencil components into a React project. With the new release this has been enforced.