fix(react): add react, react-dom and lit/react to vite externals #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwirz
changed the title
|
@christian-bromann The actual change is just this line: https://github.com/ionic-team/stencil-ds-output-targets/pull/594/files#diff-28dac5df05657e5e97b4a2230a26f8314d5920e563809a5422407526e813291aR17. However, I also added another Next.js example project using React 19 to demonstrate that it works. Additionally, I had to move and update some dependencies—I hope that’s okay. Let me know what you think! 🙏 |
christian-bromann
approved these changes
Jan 10, 2025
|
@dwirz mind rebasing the PR on top of |
dwirz
force-pushed
the
fix/do-not-bundle-deps
branch
from
26dad49 to
d65f69f
Compare
|
Big thanks @christian-bromann for merging the PR and pushing out a release! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Dependency changes were necessary because it fixes a problem with react and next.
Please check the type of change your PR introduces:
What is the current behavior?
Currently, the generated React components cannot be used with Next.js 15 and React 19, although they do work with Next.js 15 and React 18. The issue lies in the Vite build of @stencil/react-output-target, which bundles react and other dependencies into the distribution output.
Issue URL: ionic-team/stencil#6059
What is the new behavior?
With this change, react, react-dom, and @lit/react are no longer bundled into the output code of the @stencil/react-output-target.
Does this introduce a breaking change?
Other information
None.