Skip to content

chore: remove redundant words in comment #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −2
Open

chore: remove redundant words in comment #8766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/standard-operating-procedures/development/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ To release a hotfix we will aim to follow the below sub processes.

### 1. Internal Testing

Once the the PR is deemed ready for a review, as a team we can all build the hotfix branch locally, and test all the core functionality of the application, as well as hotfix functionality.
Once the PR is deemed ready for a review, as a team we can all build the hotfix branch locally, and test all the core functionality of the application, as well as hotfix functionality.

This will usually last between half a day and 1 full day. Any updates can be commited directly to the hotfix branch. When we are happy that the application passes our testings criteria we can move on to the next steps.

Expand Down
2 changes: 1 addition & 1 deletion packages/shared/lib/core/wallet/utils/processAndAddToActivities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { generateActivities, preprocessOutgoingTransaction } from '.'

// We pass the account as a parameter,
// because logging out while transaction is pending,
// clears the the selectedAccount store at this point.
// clears the selectedAccount store at this point.
export async function processAndAddToActivities(transaction: Transaction, account: IAccountState): Promise<void> {
const preprocessedTransaction = await preprocessOutgoingTransaction(transaction, account)
const activities = await generateActivities(preprocessedTransaction, account)
Expand Down