Integrate product core into identity.rs #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d4e366c.
…to GH feature branch
chrisgitiota
added
Wasm
wulfraem
requested changes
May 5, 2025
… lines across codebase
…andling in WASM bindings
…ve iota_move_calls_ts package
…iota_interaction across multiple modules
…m_identity_client
…n to use iota_interaction-ts
…e in Cargo.toml files
…r/identity.rs into chore/product-core-integration
… config_change, and upgrade modules
…ity migration tests
* Rename "product-core" dependency to "product-common" and introduce dependency patches for all product-core crates * Remove core_client, transaction_internal and wasm_transaction_signer code provided now by product-core repository * Update use statements according to new core_client location * Remove redundant code and update use statements according to new core_client location * Update examples to latest TransactionBuilder interface * Update examples to latest TransactionBuilder interface * Set @iota/iota-interaction-ts dependency to "^0.4.3" * Introduce paths in tsconfig.json files for @iota/iota-interaction-ts * Remove cargo dependency patch for local product-core files and switch product-core branch to 'chore/extend-tx-client-core' * Remove cargo dependency patch for local product-core files in identity_wasm/Cargo.toml * fix bindings build * test ts-config * clean up tsconfig * Removed unnecessary use statement * Limited visibility of core_client use to pub(crate) to avoid compiler warning * Add iota-interaction-ts/transaction_internal TS type re-export * Remove unnecessary type inference regression because TS's typesystem can infer the type now --------- Co-authored-by: Eike Haß <[email protected]>
…les to keep cargo.toml files clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is the counterpart to the
product_corePRproduct_core to be used with identity.rs.
Please see there for more details.
This PR is in draft mode and shall facilitate discussing the code changes in identity.rs
Links to any relevant issues
Fixes issue #1636.
Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
Local build with identity_iota_core e2e tests