feat: disable write stall on fullnodes perpetual db #6817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
jkrvivian
changed the base branch from
develop
to
core-node/upstream-changes/mainnet-1.32.2-1.33.3
bingyanglin
approved these changes
May 19, 2025
muXxer
reviewed
May 19, 2025
| objects_table_config(db_options.clone()), | ||
| ), | ||
| ( | ||
| "indirect_move_objects".to_string(), |
There was a problem hiding this comment.
Isn't the entry for live_owned_object_markers_table_config missing maybe?
There was a problem hiding this comment.
I added it now. I'm pretty sure it was missing.
bingyanglin
force-pushed
the
core-node/upstream-changes/mainnet-1.32.2-1.33.3
branch
from
312b9c5 to
d3c32a2
Compare
alexsporn
changed the title
muXxer
force-pushed
the
node/upstream-v1.32-1.33/42dbb
branch
from
270ec02 to
15668a7
Compare
piotrm50
approved these changes
May 21, 2025
muXxer
merged commit b6a68ab
into
core-node/upstream-changes/mainnet-1.32.2-1.33.3
33 of 35 checks passed
muXxer
added a commit
that referenced
this pull request
May 21, 2025
# Description of change Port MystenLabs/sui@42dbb62 From Sui's commit description: For fullnodes that do not prune the `perpetual` DB, especially `transactions` and `effects` cfs, they can run into write stalls occasionally that makes the fullnode non operational. Since fullnodes have to accept all writes from checkpoints, throttling writes do not seem to make much sense. Write stalling on validators is left enabled. ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement --------- Co-authored-by: muXxer <[email protected]>
muXxer
added a commit
that referenced
this pull request
May 26, 2025
# Description of change Port MystenLabs/sui@42dbb62 From Sui's commit description: For fullnodes that do not prune the `perpetual` DB, especially `transactions` and `effects` cfs, they can run into write stalls occasionally that makes the fullnode non operational. Since fullnodes have to accept all writes from checkpoints, throttling writes do not seem to make much sense. Write stalling on validators is left enabled. ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement --------- Co-authored-by: muXxer <[email protected]>
muXxer
added a commit
that referenced
this pull request
May 26, 2025
# Description of change Port MystenLabs/sui@42dbb62 From Sui's commit description: For fullnodes that do not prune the `perpetual` DB, especially `transactions` and `effects` cfs, they can run into write stalls occasionally that makes the fullnode non operational. Since fullnodes have to accept all writes from checkpoints, throttling writes do not seem to make much sense. Write stalling on validators is left enabled. ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement --------- Co-authored-by: muXxer <[email protected]>
10 tasks
muXxer
added a commit
that referenced
this pull request
May 27, 2025
# Description of change Port MystenLabs/sui@42dbb62 From Sui's commit description: For fullnodes that do not prune the `perpetual` DB, especially `transactions` and `effects` cfs, they can run into write stalls occasionally that makes the fullnode non operational. Since fullnodes have to accept all writes from checkpoints, throttling writes do not seem to make much sense. Write stalling on validators is left enabled. ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement --------- Co-authored-by: muXxer <[email protected]>
muXxer
added a commit
that referenced
this pull request
Jun 2, 2025
# Description of change Port MystenLabs/sui@42dbb62 From Sui's commit description: For fullnodes that do not prune the `perpetual` DB, especially `transactions` and `effects` cfs, they can run into write stalls occasionally that makes the fullnode non operational. Since fullnodes have to accept all writes from checkpoints, throttling writes do not seem to make much sense. Write stalling on validators is left enabled. ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement --------- Co-authored-by: muXxer <[email protected]>
muXxer
added a commit
that referenced
this pull request
Jun 2, 2025
…ainnet-1.32.2 to mainnet-1.33.3 (#6952) # Description of change This PR contains a batch of node-team related upstream changes. The changes have been individually reviewed before squash-merging. None of them modify protocol parameters, so a new protocol version is not necessary. This PR should be rebased on top of develop without squashing as it already contains squashed PRs. ## Links to any relevant issues List of included PRs: * #6179 * #6181 * #6182 * #6183 * #6334 * #6184 * #6623 * #6390 * #6414 * #6440 * #6786 * #6791 * #6817 List of included upstream commits: * MystenLabs/sui@3a68b7d * MystenLabs/sui@07f8b22 * MystenLabs/sui@3467759 * MystenLabs/sui@a22b71b * MystenLabs/sui@070a2c3 * MystenLabs/sui@6a0adb5 * MystenLabs/sui@a8e969a * MystenLabs/sui@82bf44e * MystenLabs/sui@fa7419b * MystenLabs/sui@0e78656 * MystenLabs/sui@e1abe09 * MystenLabs/sui@262390b * MystenLabs/sui@42dbb62 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ### Release Notes - [ ] Protocol: - [x] Nodes (Validators and Full nodes): * Migrate users of iota_metrics Histogram to prometheus Histogram * Rename metric names: * last_created_checkpoint_age_ms => last_created_checkpoint_age * last_certified_checkpoint_age_ms => last_certified_checkpoint_age * checkpoint_creation_latency_ms => checkpoint_creation_latency * checkpoint_contents_age_ms => checkpoint_contents_age * last_executed_checkpoint_age_ms => last_executed_checkpoint_age * checkpoint_summary_age_ms => checkpoint_summary_age * checkpoint_prepare_latency_us => checkpoint_prepare_latency * checkpoint_exec_latency_us => checkpoint_exec_latency * handle_soft_bundle_certificates_count => validator_service_handle_soft_bundle_certificates_count * handle_soft_bundle_certificates_size_bytes => validator_service_handle_soft_bundle_certificates_size_bytes * Add metric for active time of monitored futures (monitored_future_active_duration_ns) * Add metric for number of rocksdb files and level 0 files (rocksdb_total_num_files, rocksdb_num_level0_files) - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
filipdulic
pushed a commit
that referenced
this pull request
Jul 16, 2025
# Description of change Port MystenLabs/sui@42dbb62 From Sui's commit description: For fullnodes that do not prune the `perpetual` DB, especially `transactions` and `effects` cfs, they can run into write stalls occasionally that makes the fullnode non operational. Since fullnodes have to accept all writes from checkpoints, throttling writes do not seem to make much sense. Write stalling on validators is left enabled. ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement --------- Co-authored-by: muXxer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Port MystenLabs/sui@42dbb62
From Sui's commit description:
For fullnodes that do not prune the
perpetualDB, especiallytransactionsandeffectscfs, they can run into write stallsoccasionally that makes the fullnode non operational. Since fullnodes
have to accept all writes from checkpoints, throttling writes do not
seem to make much sense.
Write stalling on validators is left enabled.
Links to any relevant issues
Part of #3990
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.