-
Notifications
You must be signed in to change notification settings - Fork 33
fix(CI): Fix rust CI failing on fromJson
with an empty changes list
#6852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DaughterOfMars
wants to merge
2
commits into
develop
Choose a base branch
from
dev-tools/fix-rust-ci-empty-changes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
46ccf0d
to
53f0852
Compare
marc2332
approved these changes
May 13, 2025
muXxer
approved these changes
May 13, 2025
53f0852
to
1cd2d6e
Compare
thibault-martinez
requested changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to sign your commits
ummmm what??? Was this because of the rebase? |
1cd2d6e
to
a362f83
Compare
a362f83
to
85fb224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Issues related to our CI pipeline
dev-tools
Issues related to the Developer Tools Team
sc-platform
Issues related to the Smart Contract Platform group.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Currently it seems that the CI will fail with the following error when no changes are detected for the rust workflow.
Type of change
Choose a type of change, and delete any options that are not relevant.