Skip to content

fix(CI): Fix rust CI failing on fromJson with an empty changes list #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

DaughterOfMars
Copy link
Contributor

Description of change

Currently it seems that the CI will fail with the following error when no changes are detected for the rust workflow.

iotaledger/iota/.github/workflows/_rust.yml@d2bed6d0e1b0d87c548b5b594ad6353773a4b65b (Line: 86, Col: 22): Error from function 'fromJson': empty input

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

Copy link

vercel bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 7:42pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 7:42pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 7:42pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 13, 2025 7:42pm

@github-actions github-actions bot added the ci Issues related to our CI pipeline label May 13, 2025
@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels May 13, 2025
@DaughterOfMars DaughterOfMars force-pushed the dev-tools/fix-rust-ci-empty-changes branch 2 times, most recently from 46ccf0d to 53f0852 Compare May 13, 2025 08:55
@DaughterOfMars DaughterOfMars force-pushed the dev-tools/fix-rust-ci-empty-changes branch from 53f0852 to 1cd2d6e Compare May 13, 2025 11:48
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to sign your commits

@DaughterOfMars
Copy link
Contributor Author

You need to sign your commits

ummmm what??? Was this because of the rebase?

@DaughterOfMars DaughterOfMars force-pushed the dev-tools/fix-rust-ci-empty-changes branch from 1cd2d6e to a362f83 Compare May 13, 2025 19:35
@DaughterOfMars DaughterOfMars force-pushed the dev-tools/fix-rust-ci-empty-changes branch from a362f83 to 85fb224 Compare May 13, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to our CI pipeline dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants