Feat: Make package registry downward compatible #74
+227
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The release of the Full Package History in product-core needs to be non breaking (or backward compatible) so that products using the already existing version of the PackageRegistry can use the new version without changes.
For this purpose this PR changes the following:
tomldependency back to be static.To prevent existing projects from having build issues, the static
tomldepency needs to be maintained.As soon as all products have migrated to use the MoveHistoryManager and the legacy PackageRegistry functions
(marked as deprecated now) have been removed, we can reactivate the
tomldependency being controlled bythe
move-history-managerfeature flag.The legacy versions of the functions
insert_envandfrom_move_lock_contenthave been restored and the newversion of
insert_envhas been renamed toinsert_env_historyto be distinguishable.Products using legacy
PackageRegistryfunctions that have been marked as deprecated now need to add the#[allow(deprecated)]macro everywhere where those deprecated functions and types are used in their code.Links to any relevant issues
fixes iotaledger/notarization#71
How the change has been tested
This PR is tested using these Identity and Notarization PRs: