tools/criticalstat: Update error message with kernel version-specific… #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config requirements
The kernel configurations required for preempt/irq tracepoints changed in Linux 4.19
due to commit c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and unify
their usage"). This patch updates the error messages and documentation to clearly
specify which kernel configurations should be enabled based on kernel version:
- For kernel 4.19 and later:
CONFIG_PREEMPTIRQ_TRACEPOINTS, CONFIG_TRACE_IRQFLAGS, CONFIG_TRACE_PREEMPT_TOGGLE
- For kernel 4.15 to 4.18:
CONFIG_PREEMPTIRQ_EVENTS, CONFIG_PROVE_LOCKING
Common requirements for all versions:
- CONFIG_DEBUG_PREEMPT
- CONFIG_PREEMPT_TRACER
Additionally, CONFIG_LOCKDEP should be disabled on older kernels.
These changes make it easier for users to identify and enable the correct
configuration options for their specific kernel version.
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c3bc8fd637a9
Signed-off-by: Ism Hong <[email protected]>
ismhong
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… config requirements
The kernel configurations required for preempt/irq tracepoints changed in Linux 4.19 due to commit c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and unify their usage"). This patch updates the error messages and documentation to clearly specify which kernel configurations should be enabled based on kernel version:
For kernel 4.19 and later: CONFIG_PREEMPTIRQ_TRACEPOINTS, CONFIG_TRACE_IRQFLAGS, CONFIG_TRACE_PREEMPT_TOGGLE
For kernel 4.15 to 4.18: CONFIG_PREEMPTIRQ_EVENTS, CONFIG_PROVE_LOCKING
Common requirements for all versions:
Additionally, CONFIG_LOCKDEP should be disabled on older kernels.
These changes make it easier for users to identify and enable the correct configuration options for their specific kernel version.
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c3bc8fd637a9