tcpdrop: add support for dumping TCP drop reasons #5252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioworker0
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
|
Besides the bugfix[1], let's also take advantage of drop reasons; they will be very helpful for that purpose, as other eBPF tools like nettrace have already done ;) [1] #5250 Cc @chenhengqi |
chenhengqi
reviewed
Mar 23, 2025
ioworker0
force-pushed
the
feat/drop-reason
branch
from
6b0a7aa to
d247803
Compare
This commit adds support for dumping TCP drop reasons. It maps these reasons to human-readable strings, making it easier to understand why TCP packets are dropped. In cases where the drop reason is not supported, 'NOT_SPECIFIED' will be displayed. Signed-off-by: Mingzhe Yang <[email protected]> Signed-off-by: Lance Yang <[email protected]>
ioworker0
force-pushed
the
feat/drop-reason
branch
from
d247803 to
80ebc4b
Compare
|
Gently ping @chenhengqi |
|
Just merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for dumping TCP drop reasons. It maps these reasons
to human-readable strings, making it easier to understand why TCP packets
are dropped. In cases where the drop reason is not supported, 'NOT_SPECIFIED'
will be displayed.