libbpf-tools/readahead: Fix low page usage count since v5.15 #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Linux 5.15, `mark_page_accessed` is no longer called in `filemap_read`, which causes increased counts of unused page cache. This patch attempts to attach `mark_accessed` to `folio_mark_accessed` if it is available; otherwise, it falls back to using `mark_page_accessed`. Signed-off-by: B106Roger <[email protected]>
B106Roger
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
| SEC("fentry/folio_mark_accessed") | ||
| int BPF_PROG(folio_mark_accessed, struct folio *folio) | ||
| { | ||
| mark_accessed(&folio->page); |
There was a problem hiding this comment.
'return mark_accessed(&folio->page)'? Similar issue below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Linux 5.15,
mark_page_accessedis no longer called infilemap_read, which causes increased counts of unused page cache.(For more detail, please refers to
mark_page_accessedin Linux Patch1 andfilemap_readin Linux Patch2.)This patch attempts to attach
mark_accessedtofolio_mark_accessedif it is available; otherwise, it falls back to usingmark_page_accessed.Linux Patch1: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76580b65
Linux Patch2: torvalds/linux@6020c20#diff-6f046052d9af59ceb36616faffd8b1920c28195619803cfdb25df7271200ba5e