Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap/client/internal/messagequeue: run tests in parallel #835

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Feb 6, 2025

On my computer, make the tests take 12s rather than 65s. Skimming through them I didn't found any dependency or shared resources in them.

On my computer, make the tests take 12s rather than 65s.
Skimming through them I didn't found any dependency or shared resources in them.
@Jorropo Jorropo requested a review from a team as a code owner February 6, 2025 16:50
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (7c1f0a3) to head (d6f7b22).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   60.49%   60.47%   -0.03%     
==========================================
  Files         244      244              
  Lines       31136    31136              
==========================================
- Hits        18837    18828       -9     
- Misses      10620    10630      +10     
+ Partials     1679     1678       -1     

see 7 files with indirect coverage changes

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@gammazero gammazero merged commit 4985f93 into ipfs:main Feb 6, 2025
13 of 14 checks passed
@Jorropo Jorropo deleted the fast-test/messagequeue branch February 6, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants