generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from gogo protobuf #838
Draft
gammazero
wants to merge
3
commits into
main
Choose a base branch
from
move-from-gogo-protobuf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to go-libp2p-kad-dht v0.29.0
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 60.55% 61.66% +1.11%
==========================================
Files 244 238 -6
Lines 31136 29882 -1254
==========================================
- Hits 18855 18428 -427
+ Misses 10604 9886 -718
+ Partials 1677 1568 -109
|
aschmahmann
reviewed
Feb 7, 2025
|
||
package unixfs_pb | ||
package pb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gammazero if possible I would:
- Separate switching everything but UnixFS from the UnixFS switch
- If / when switching UnixFS be very careful in checking that the generated protobufs should be byte-wise identical (includes validating in kubo, etc. that data imports result in the same CIDs, etc.)
102f08e
to
f299fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.