Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from gogo protobuf #838

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Move from gogo protobuf #838

wants to merge 3 commits into from

Conversation

gammazero
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 50.10989% with 227 lines in your changes missing coverage. Please review.

Project coverage is 61.66%. Comparing base (9e4f046) to head (102f08e).

Files with missing lines Patch % Lines
bitswap/message/pb/message.pb.go 36.45% 126 Missing and 3 partials ⚠️
ipld/unixfs/pb/unixfs.pb.go 57.03% 56 Missing and 2 partials ⚠️
bitswap/message/message.go 65.90% 13 Missing and 2 partials ⚠️
filestore/pb/dataobj.pb.go 76.36% 12 Missing and 1 partial ⚠️
filestore/util.go 0.00% 7 Missing ⚠️
filestore/fsrefstore.go 60.00% 4 Missing ⚠️
bitswap/testnet/virtual.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   60.55%   61.66%   +1.11%     
==========================================
  Files         244      238       -6     
  Lines       31136    29882    -1254     
==========================================
- Hits        18855    18428     -427     
+ Misses      10604     9886     -718     
+ Partials     1677     1568     -109     
Files with missing lines Coverage Δ
ipld/unixfs/unixfs.go 79.93% <ø> (ø)
routing/offline/offline.go 72.72% <ø> (ø)
bitswap/testnet/virtual.go 68.42% <0.00%> (-2.20%) ⬇️
filestore/fsrefstore.go 42.45% <60.00%> (+0.54%) ⬆️
filestore/util.go 0.00% <0.00%> (ø)
filestore/pb/dataobj.pb.go 73.01% <76.36%> (+34.69%) ⬆️
bitswap/message/message.go 81.49% <65.90%> (-2.94%) ⬇️
ipld/unixfs/pb/unixfs.pb.go 54.32% <57.03%> (+6.38%) ⬆️
bitswap/message/pb/message.pb.go 35.34% <36.45%> (+5.60%) ⬆️

... and 15 files with indirect coverage changes


package unixfs_pb
package pb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gammazero if possible I would:

  1. Separate switching everything but UnixFS from the UnixFS switch
  2. If / when switching UnixFS be very careful in checking that the generated protobufs should be byte-wise identical (includes validating in kubo, etc. that data imports result in the same CIDs, etc.)

@gammazero gammazero force-pushed the move-from-gogo-protobuf branch from 102f08e to f299fcb Compare February 7, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants