Queries With No Blocks #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acruikshank
reviewed
Jan 22, 2021
| linkTracker := prs.getLinkTracker(requestID) | ||
| isUnique = linkTracker.BlockRefCount(link) == 0 | ||
| _, noBlockRequest := prs.noBlockRequests[requestID] | ||
| isUnique = linkTracker.BlockRefCount(link) == 0 && !noBlockRequest |
There was a problem hiding this comment.
isUnique is now misleading. shouldSend?
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| assertSentNotOnWire(t, bd1, blks[0]) |
There was a problem hiding this comment.
Could we change this to assertNotSentOnWire? I assume this tests that the block is not sent at all, instead of it being sent but not on the wire like the name suggests.
| return nil | ||
| }) | ||
| require.NoError(t, err) | ||
| fph.AssertResponses(expectedResponses{ |
There was a problem hiding this comment.
Should there be an assertion that the blks[0] was sent? I would expect that it was since IgnoreAllBlocks has not been called for requestID2, and I assume that's the point of this second transaction. Some comments on what the different sections of this test are trying to achieve would be helpful.
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.