Skip to content

fix: SweepingProvider slow start #10980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

fix: SweepingProvider slow start #10980

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5ec66e
fix: SweepingProvider slow start #10979
guillaumemichel Sep 19, 2025
9753213
don't purge keystore
guillaumemichel Sep 23, 2025
3862acd
feat: add INFO logging for provider keystore sync
lidel Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions core/node/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,18 @@ func SweepingProviderOpt(cfg *config.Config) fx.Option {
// replace them with the keys that needs to be reprovided, coming from
// the KeyChanFunc. So far, this is the less worse way to remove CIDs
// that shouldn't be reprovided from the provider's state.
if err := syncKeyStore(ctx); err != nil {
return err
}
go func() {
// Sync the keystore once at startup. This operation is async since
// we need to walk the DAG of objects matching the provide strategy,
// which can take a while.
strategy := cfg.Provide.Strategy.WithDefault(config.DefaultProvideStrategy)
logger.Infow("provider keystore sync started", "strategy", strategy)
if err := syncKeyStore(ctx); err != nil {
logger.Errorw("provider keystore sync failed", "err", err, "strategy", strategy)
} else {
logger.Infow("provider keystore sync completed", "strategy", strategy)
}
}()

gcCtx, c := context.WithCancel(context.Background())
cancel = c
Expand Down Expand Up @@ -462,10 +471,10 @@ func SweepingProviderOpt(cfg *config.Config) fx.Option {
case <-ctx.Done():
return ctx.Err()
}
// KeyStore state isn't be persisted across restarts.
if err := in.KeyStore.Empty(ctx); err != nil {
return err
}

// Keystore data isn't purged, on close, but it will be overwritten
// when the node starts again.

return in.KeyStore.Close()
},
})
Expand Down
Loading