Improve the stability of the tokenizer #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of the tokens could fail. To fix this move to the
cborg provided compare method.
rvagg
reviewed
Dec 4, 2024
Comment on lines
+170
to
+171
| "eslint-config-ipfs": "^7.0.6", | ||
| "eslint-plugin-n": "^17.14.0" |
There was a problem hiding this comment.
aegir should be contributing what it needs for linting, no? does it fail without these?
There was a problem hiding this comment.
it does fails without on my side.
There was a problem hiding this comment.
try removing these and push again, this changeset works for me locally without them and pushing a new commit might wake CI up, something odd going in GitHub Actions even after a re-start attempt
There was a problem hiding this comment.
$ npm ls --all | grep 'eslint-config-ipfs\|eslint-plugin-n'
│ │ ├─┬ [email protected]
│ │ │ ├─┬ [email protected]
│ │ │ ├── [email protected] deduped
│ │ ├── [email protected]
│ │ ├── [email protected] deduped
│ ├─┬ [email protected]
this is from a freshly installed tree without them, so they're there already from aegir.
|
The failures in the CI i don't understand --- they are all released to the git checkouts --- any ideas. |
|
that's what happens here if i remove the eslint deps: |
|
Sorry, if I run the exact same commands I don't get that error. What version of Node.js and npm are you doing this on? |
$ node -v if i use: and remove the additional deps --- i get the same error as with the other versions. my .npmrc a almost clean: that's enough investigation for me now --- I will just remove these imports |
|
I've tried it locally on a fresh checkout without the additional deps. It works for me. $ node -v
v20.13.1
$ npm -v
10.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some oddities with esm.sh, the object compare of the tokens could fail.
To fix this, make use of cborg provided Type.compare method.
I'm sorry for the package.json changes but they are needed if I want to run the tests locally.