Update matrix for solidity #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How do we define "ready"? I assume "PR is merged" |
pdobacz
approved these changes
May 22, 2024
There was a problem hiding this comment.
lgtm. Since it's early prototype at this stage, I think 🚧 is the valid emoji.
OTOH I wonder if 3540 and 5450 shouldn't be marked somehow. 3540 may even be a 👍 - since the implementation does generate valid containers, leveraging all their features. 5450 - 👍 only after we're sure we've leveraged the relaxed stack validation, reaping the benefits it promised.
On yet another hand, I don't think having PRs merged upstream should matter per se, many of the 👍's still reside in feature branches.
chfast
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.