Add generic Google handlers #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the generic package support to include Google authenticators It generates separate packages for "hosted-domain" and "email-lookup" validation types, but does not yet include one for "google-groups" as that requires a JSON file at runtime; need to determine a good option to supply that as a secret.
bsneider
reviewed
Sep 15, 2021
| case 'groups-lookup': | ||
| config.SUBDIST = isGeneric && "groups_lookup"; | ||
| if (isGeneric) { | ||
| // TODO: provide a base64 encoded method for user-supplied google-authz.json |
There was a problem hiding this comment.
would be nice, i guess, if you wanted to support groups-based lookups.. not something i currently need though
| const getParametersByPathPromise = ssm.getParametersByPath({ Path: `/${name}`, WithDecryption: true }).promise(); | ||
|
|
||
| // Get key pair from Secrets Manager | ||
| const secretsmanager = new aws.SecretsManager({ region: 'us-east-1' }); |
There was a problem hiding this comment.
Lambda@Edge functions must be deployed in us-east-1, so i'm not sure there's any value in making the region configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iress given your PR is still pending, perhaps it'd be worth adding my Google update to it (feedback welcome)
This commit extends the generic package support to include Google
authenticators
It generates separate packages for "hosted-domain" and "email-lookup"
validation types, but does not yet include one for "google-groups" as
that requires a JSON file at runtime; need to determine a good option to
supply that as a secret.