Conversation
| REGISTRY_URL=$(prompt_nonempty "Enter registry URL") | ||
| REGISTRY_NAMESPACE=$(prompt_nonempty "Enter image repository path (e.g. myteam/iriusrisk-prod)") | ||
| REGISTRY_USERNAME=$(prompt_nonempty "Enter registry username") | ||
| container_registry_login |
There was a problem hiding this comment.
Are we trying a docker/podman login before install (ensure) the packages then here? (if Custom registry)
I may be wrong but seems we are calling prompt_registry_settings before install the packages at one-click.sh
There was a problem hiding this comment.
Correct. I changed it so that you set a custom registry once and it used for all images, given that if our clients aren't allowed to use public repositories and must use an internal one, they aren't going to select yes on using the default public postgres image repository. That being the case, we need to log in to said registry immediately so that if the client chooses to install postgres on the same server, it can be pulled from the custom registry, and if they choose to set up Jeff, they can pull the redis image from their own registry.
There was a problem hiding this comment.
Oh hang on I may have misread you, let me check something.
There was a problem hiding this comment.
I've moved the registry prompt and update_compose_image_placeholders call to after dependencies are installed and before we set up Postgres. Quick test with docker, working correctly.
| # 3. Compute compose context and stop the stack cleanly | ||
| # Compute compose context and stop the stack cleanly | ||
| # ————————————————————————————————————————————————————————————— | ||
| COMPOSE_OVERRIDE=$(build_compose_override "$USE_INTERNAL_PG") |
There was a problem hiding this comment.
One more thing, just to be sure before approval
Do we need to define COMPOSE_OVERRIDE here before the first compose down?
Great work as always, every time I get more vertigo with this repo :)
There was a problem hiding this comment.
Good catch, I had to move it around to accommodate Jeff but missed this. It still worked as the down command evaulates to just docker-compose down. I've pushed a commit to compute the pre-rollback down command and then the post rollback/file restoration down command, and tested with docker.
…grade, clarified image requirements for redis and postgres
Summary
Key Changes
Compose File Management
git pullcauses merge conflictsPodman Secrets Handling
/run/secrets, then loaded into environment variables by containers/run/secretsautomaticallyTesting
Comprehensive testing was performed across all supported combinations:
Ubuntu / Docker
Fresh Install
Upgrade
RHEL / Podman
Fresh Install
Upgrade
Rollback & Upgrade Improvements