Conversation
…+ bump Ash to 1.9.0
…note, trim AI images list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Jeff/Ash AI assistant from GEMINI API key auth to GCP Service Account (JWT/RS256) flow, and bumps Ash to 1.9.0.
Changes
ai-ash-1.7.0→ai-ash-1.9.0GEMINI_ENDPOINT/GEMINI_API_KEYwithPROJECT_ID,GEMINI_REGION, and GCP Service Account JSON (GCP_S_A_CREDENTIALS)check_gemini_api(): Rewritten to perform full GCP SA JWT (RS256) token exchange via Google OAuth2, then calls Vertex AIgenerateContentAPIprompt_jeff_config(): Updated prompts for GCP Project ID, region, and SA JSON key pasteconfigure_jeff_file(): Replaces old Gemini endpoint/key sed ops with new GCP fields; inlines SA JSON into compose via Pythonvalidate_preserved_values()/capture_preserved_values(): Updated key names to match new flowpreflight.sh: Updated Jeff AI credential checks accordingly