[irods/irods#7985] Remove reference to AclPolicy in template (main)

[MartinFlores751]

Issue quick link: irods/irods#7985.
Companion PR to: irods/irods#8264.

This PR removes a reference to both an msi and a static PEP in core.py.template.

[alanking]

Seems good. Consider running a test which is known to have previously invoked this policy along with the changes in the companion PR to make sure nothing blows up? Probably don't need to run the whole test suite.

[MartinFlores751]

Do we have a pointer to when the acAclPolicy static pep is fired? It might help figure out a test that calls it then.

[korydraughn]

Just starting the server is enough to test it. To take it a step further, invoking GenQuery1, as a rodsuser, to list another user's collection should cover it.

[alanking]

Looks like it's called in _rsGenQuery, so probably pretty much everything runs through here at least once per agent lifetime (spotted some "caching" logic in there as well, so it may only happen once per agent). Try putting a writeLine call in there and see which iCommands cause it to print something out. I'm thinking pretty much any iCommand which runs a query will do.

[MartinFlores751]

Failed to build:

stderr: /irods_plugin_source/src/types/irods/getRodsEnv.cpp:102:81: error: no member named 'irodsPluginHome' in 'RodsEnvironment'
                        .add_property("irodsPluginHome", +[](rodsEnv *s) { return array_ref<char>{s->irodsPluginHome}; })
                                                                                                  ~  ^
/irods_plugin_source/src/types/irods/getRodsEnv.cpp:102:37: error: invalid argument type '(lambda at /irods_plugin_source/src/types/irods/getRodsEnv.cpp:102:38)' to unary expression
                        .add_property("irodsPluginHome", +[](rodsEnv *s) { return array_ref<char>{s->irodsPluginHome}; })
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/irods_plugin_source/src/types/irods/getRodsEnv.cpp:65:16: error: no member named 'irodsPluginHome' in 'RodsEnvironment'
                                        &rodsEnv::irodsPluginHome,
                                         ~~~~~~~~~^

It looks like this might have been changed to irodsPluginDirectory in 5.0?

[korydraughn]

That's correct. The property was renamed in iRODS 5 and should / will be deprecated in iRODS 4.