Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Focus and button syling in name manager #243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX: Focus and button syling in name manager #243

wants to merge 1 commit into from

Conversation

dg-ac
Copy link
Contributor

@dg-ac dg-ac commented Jan 15, 2025

Hey there,

I made a couple of extra small adjustments to the name manager:

  • Keyboard focus works now as expected,
  • and buttons styling (added the state focusVisible and changed disabled a bit)

Thanks,
D

nhatcher
nhatcher requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@nhatcher nhatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dg-ac , you will need to rebase the main branch. It might be easier to start from scratch.

webapp/src/components/NameManagerDialog/NameManagerDialog.tsx
@@ -84,7 +84,7 @@ function NameManagerDialog(properties: NameManagerDialogProperties) {
<StyledBox>{t("name_manager_dialog.range")}</StyledBox>
<StyledBox>{t("name_manager_dialog.scope")}</StyledBox>
</StyledRangesHeader>
<NameListWrapper>
<NameListWrapper tabIndex={-1}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why are you doing this?

webapp/src/components/NameManagerDialog/NamedRangeActive.tsx
@@ -92,12 +92,14 @@ function NamedRangeActive(properties: NamedRangeProperties) {
}
}}
title={t("name_manager_dialog.apply")}
disableFocusRipple={true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhatcher nhatcher nhatcher requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg-ac @nhatcher