fix: implement correct usage of History actions#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Main branch is to fix issue #37, the merge of this closes it.
Also revamped some UI regarding editing an expense and did a major deocuple/refactor regarding all components and UI for History section.
Change strategy
Made the usage correctly for SwipeableActions per item on the list of transactions and recurring expenses.
Also decoupled a lot of the HistoryScreen, merge and organized using packages like:
RecurrenceConfigSheetthat lives insidehistory.editand some other components like bottom sheets insidehistory.dialogsImplemented
New packages
editdialogssectioninside the history package to better find and decouple a lot of components insideHistorySections. Which now it doesn't exist and now it only renders each file if needed instead of having the whole thing.Working demo
Demo of the fix applied:
https://github.com/user-attachments/assets/0ffbd2a3-8742-4d12-a58d-e9a642dfaec1
Demo of the new UX regarding editing an expense
https://github.com/user-attachments/assets/5f1f83bc-f36c-4f89-8d9f-374ec07dfb3e
Testing
Added new file for testing editing a transaction:



./gradlew :app:compileDebugKotlin :wear:compileDebugKotlin :sync-contract:compileKotlin :app:testDebugUnitTestNotes
N/A