feat: Splash screen implementation and correct nav handling#5
Merged
Conversation
…est coverage refactor: reorganize package structure and add comprehensive test coverage
- **Core UI**: Integrated `androidx-core-splashscreen` and configured a new `Theme.Sorter.Splash` to handle app startup. - **Navigation**: Enhanced `NavigationViewModel` to manage an `isReady` state, ensuring the splash screen persists until the initial start screen (Sorter or Onboard) is determined. - **Testing**: Added extensive instrumented tests for `ReviewScreen`, `SettingsScreen`, `TutorialScreen`, and `SorterMediaScreen`. - **Instrumentation**: Added `testTag` modifiers across multiple components to facilitate reliable UI testing. - **Fixes**: Corrected internal theme package references across several presentation components. - **Chore**: Updated Hilt dependencies to `2.57.2` and enabled the KSP plugin in the build configuration. Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
isaacsa51
changed the title
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding correct splash screen implementation following android docs.
Created UI tests for compose screens.
Type of Change
Related Issue
N/A
Changes Made
testNodesin composeTesting
./gradlew testDebugUnitTest)./gradlew lint)./gradlew assembleDebug)Test Environment: