Skip to content

Add passive config option flag to auth command#156

Open
llewelld wants to merge 1 commit intoisambard-sc:masterfrom
llewelld:154-passive-auth
Open

Add passive config option flag to auth command#156
llewelld wants to merge 1 commit intoisambard-sc:masterfrom
llewelld:154-passive-auth

Conversation

@llewelld
Copy link
Copy Markdown
Contributor

@llewelld llewelld commented Dec 19, 2025

Adds a "passive" config option and flag to the auth command. When
enabled the certificates are checked for validity and authentication
happens only if one of the certificates has expired.

@llewelld
Copy link
Copy Markdown
Contributor Author

llewelld commented Dec 19, 2025

This is very much a work in progress and I'm liable to force push to this branch.

@llewelld
Copy link
Copy Markdown
Contributor Author

Contributes to #154.

Adds a "passive" config option and flag to the auth command. When
enabled the certificates are checked for validity and authentication
happens only if one of the certificates has expired.
@llewelld llewelld changed the title Add passive flag, move auth code to auth.rs Add passive config option flag to auth command Dec 20, 2025
@llewelld
Copy link
Copy Markdown
Contributor Author

llewelld commented Dec 20, 2025

It seems to be working now so I've moved this out of draft. Some notes:

  1. The flag I've used is passive but it could also be something like force with the opposite semantics?
  2. With the additional code the auth branch was getting a bit unwieldy so I moved it into the auth.rs file. I'm not sure whether this fits the intention with the structure, it could go somewhere else or stay in main.rs; please say if I should change this.
  3. The code checks whether certificates exist and whether they've expired. Should it be checking anything else?

@llewelld llewelld marked this pull request as ready for review December 20, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant