Filtering module - added reflect boundary fill #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: seyeonjeon <[email protected]>
…o filtering Conflicts: src/dolphin/filtering.py tests/test_filtering.py
…o filtering Conflicts: src/dolphin/filtering.py
reflect fill using np.pad
scottstanie
reviewed
Dec 4, 2024
There was a problem hiding this comment.
The main concern besides the unit tests are failing is- what would happen on a frame with half-filled data? that is, for some coastal areas, the image could still be large, but mostly nodata; will that error? or just produce sub-optimally filled results (not as bad)
| def _fill_boundary_area(unw_ifg_interp: np.ndarray, mask: np.ndarray) -> np.ndarray: | ||
| """Fill the boundary area by reflecting pixel values.""" | ||
| # Rotate the data to align the frame | ||
| rt_unw_ifg = ndimage.rotate(unw_ifg_interp, 8.6, reshape=False) |
There was a problem hiding this comment.
we'll want a parameter for the rotation in degrees:
- inputs in radar coordinates will need no rotation
- ascending and descending geocoded inputs would take the opposite rotation amounts
There was a problem hiding this comment.
we'll also probably want some parameter to indicate wither there's any fill requested at all- a radar image filled all the way to the borders doesn't need this reflection
Comment on lines
+114
to
+136
| rt_pad = 700 # Apply padding for rotating back | ||
| # Fill boundary area using np.pad for each horizontal step and | ||
| reflect_filled = np.pad( | ||
| rt_unw_ifg[846:6059, :], | ||
| ((846, rt_unw_ifg.shape[0] - 6059), (0, 0)), | ||
| mode="reflect", | ||
| ) | ||
| reflect_filled = np.pad( | ||
| reflect_filled[618:6241, :], | ||
| ((618, rt_unw_ifg.shape[0] - 6241), (0, 0)), | ||
| mode="reflect", | ||
| ) | ||
| reflect_filled = np.pad( | ||
| reflect_filled[399:6447, :], | ||
| ((399 + rt_pad, rt_unw_ifg.shape[0] - 6447 + rt_pad), (0, 0)), | ||
| mode="reflect", | ||
| ) | ||
| # Fill vertical boundary area using np.pad | ||
| reflect_filled = np.pad( | ||
| reflect_filled[:, 591:8861], | ||
| ((0, 0), (591 + rt_pad, rt_unw_ifg.shape[1] - 8861 + rt_pad)), | ||
| mode="reflect", | ||
| ) |
There was a problem hiding this comment.
for these numbers, we'll want to note the assumptions behind them
- how they were found
- what size images they apply to (i believe it's part of why the unit tests are failing)
- ideally giving some kind of names, rather than leaving them as magic numbers
|
Closing in favor of #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reflect boundary fill using np.pad in filtering module.