Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stamp #18

Merged
merged 13 commits into from
Jul 9, 2024
Merged

feat: stamp #18

merged 13 commits into from
Jul 9, 2024

Conversation

punchanabu
Copy link
Member

No description provided.

@punchanabu punchanabu self-assigned this Jul 5, 2024
@punchanabu punchanabu marked this pull request as draft July 5, 2024 16:42
@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firstdate-rpkm67-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 2:48pm

TeeGoood
TeeGoood requested changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@TeeGoood TeeGoood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix stamp checkbox size

@punchanabu punchanabu marked this pull request as ready for review July 8, 2024 19:34
@punchanabu punchanabu changed the title [WIP] feat: stamp feat: stamp Jul 8, 2024
@punchanabu punchanabu requested a review from TeeGoood July 8, 2024 19:34
@punchanabu
Copy link
Member Author

PR Description

  • Stamp page and api stamp integration
  • We can acquire a stamp by using an OTP Modal provided or just put some text in the Text Modal for the last two stamps
  • I use react-hot-toast to visualize result for retrieving stamp

TeeGoood
TeeGoood requested changes Jul 9, 2024
View reviewed changes
src/app/stamp/page.tsx Outdated Show resolved Hide resolved
src/app/stamp/page.tsx Outdated Show resolved Hide resolved
src/utils/stamp.ts Outdated Show resolved Hide resolved
@punchanabu punchanabu requested a review from TeeGoood July 9, 2024 14:49
TeeGoood
TeeGoood approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@TeeGoood TeeGoood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@TeeGoood TeeGoood merged commit 45687c6 into main Jul 9, 2024
3 checks passed
@TeeGoood TeeGoood deleted the punpun-fe/fdr-36-stamp branch July 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeeGoood TeeGoood TeeGoood approved these changes

Assignees

@punchanabu punchanabu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punchanabu @TeeGoood