Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest v3 rebase #5

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Manifest v3 rebase #5

merged 7 commits into from
Jun 7, 2022

Conversation

kawazoe
Copy link

@kawazoe kawazoe commented Jun 7, 2022

Rebuild of the initial manifest-v3 branch to include all the most recent changes. Since the original branch was non-functional, I haven't tested this new revision either. This PR will give us a stable place to work on, add new features, and mostly make future code review simpler by limiting the scope of changes.

Note:
@ish- initially asked for a rebase in #4 but after doing the merge, I'm not so sure this was a good idea. GitHub won't be able to handle the merge automatically. I propose this should be the last rebase we do on this branch and everything else gets done via cherry-picks and merges.

Followup:
The next PR will be about standardizing the code style and making sure that everyone can edit the code no matter their IDE or OS. After that, I'll be good to go for a fix.

Copy link
Owner

@ish- ish- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you actualy need .idea folder here? )

@ish- ish- merged commit 7082aef into ish-:manifest-v3 Jun 7, 2022
@kawazoe
Copy link
Author

kawazoe commented Jun 7, 2022

do you actualy need .idea folder here? )

Not necessarily. Alternatively, I could add the whole .idea folder to the gitignore file instead.

This is just useful for sharing project level settings with other people who might be using this IDE (like code style rules), a bit like the .vscode folder, if that's what you use. Ignoring the whole folder would prevent that.

EDIT: As a note, I plan to add an editorconfig file in my next PR to try to automate the code styling work a bit, but it might not support everything that WebStorm or VSCode would. This is a good example of where those additional configs would go if we keep the folder.

EDIT2: I managed to get all of the WebStorm's settings I needed into the editorconfig file, so it's totally fine to gitignore the whole folder if you want.

@kawazoe
Copy link
Author

kawazoe commented Jun 11, 2022

@ish- I know this is already merged, but could you take a look at my previous reply?

@ish-
Copy link
Owner

ish- commented Jun 13, 2022

@kawazoe feel free about it, it's not that serious ж)

@kawazoe kawazoe deleted the manifest-v3 branch December 27, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants