Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new GitHub Workflow to build, test, and publish a Node.js project similarly to an Azure DevOps Pipeline.
- Added a workflow file (.github/workflows/ci.yml) that defines jobs for checking out code, installing Node.js, building, testing, and publishing the package.
- Configured additional steps for uploading test results, code coverage, and the npm package tarball.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a GitHub Workflow for CI/CD while updating the SauceLabs configuration in the Karma test configuration file.
- Update SauceLabs settings in karma.conf.js (platform, version, platformVersion, appiumVersion).
- Introduce a new GitHub Workflow in .github/workflows/ci.yml for building, testing, and publishing.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| karma.conf.js | Updated SauceLabs configuration for Safari and iOS support |
| .github/workflows/ci.yml | Added a new GitHub Workflow to replace the Azure DevOps pipeline |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
karma.conf.js:99
- [nitpick] The prefix 'XXX' in the browser configuration name appears to be a placeholder; consider renaming to a more descriptive identifier.
XXXsl_android_chrome: {
seanpoulter
changed the title
jcubic
left a comment
jcubic
left a comment
There was a problem hiding this comment.
Looks good, I will add the secrets tomorrow.
seanpoulter
changed the title
|
I split out the change to fix the Azure DevOps pipeline into #132. There's no rush to set up the secrets. |
seanpoulter
force-pushed
the
build-in-gh-workflow
branch
from
060925b to
f909fef
Compare
seanpoulter
force-pushed
the
build-in-gh-workflow
branch
from
f909fef to
9ddd1bf
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a GitHub Workflow to build, test, and publish the project, similar to an existing Azure DevOps pipeline.
- Introduces a new CI workflow with steps for checkout, Node.js setup, dependency installation, building and testing the application, packaging artifacts, and publishing to npm.
|
The secrets worked! Thanks @jcubic! 👏 This is ready for one last look and we can merge. Unfortunately a |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new GitHub Actions workflow for building, testing, and packaging a Node.js project, similar to the existing Azure DevOps Pipeline.
- Adds a continuous integration workflow for pull requests with steps to install Node.js, install dependencies, run build/tests, and package & publish artifacts.
- Implements concurrency and conditional steps for artifact uploads and publishing to npm.
| npm pack | ||
|
|
||
| - name: Save npm-tarball.tgz | ||
| if: ${{ !cancelled() && !github.event.pull_request.head.repo.fork }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: npm-tarball.tgz | ||
| path: isomorphic-git-lightning-fs-0.0.0-development.tgz |
There was a problem hiding this comment.
[nitpick] Consider parameterizing or verifying the hardcoded tarball file name so that it matches the package version dynamically when changes occur.
| npm pack | |
| - name: Save npm-tarball.tgz | |
| if: ${{ !cancelled() && !github.event.pull_request.head.repo.fork }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: npm-tarball.tgz | |
| path: isomorphic-git-lightning-fs-0.0.0-development.tgz | |
| TAR_NAME=$(npm pack | tail -n 1) | |
| echo "TAR_NAME=$TAR_NAME" >> $GITHUB_ENV | |
| - name: Save npm-tarball.tgz | |
| if: ${{ !cancelled() && !github.event.pull_request.head.repo.fork }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: npm-tarball.tgz | |
| path: ${{ env.TAR_NAME }} |
|
Looks good, we need to get rid of the Copilot SPAM. Do you know how to disable this thing? |
|
Oh, just noticed that you added request for it. If you like to fix those issue he reported, go ahead. |
Sorry, I've been experimenting with it and ignoring it the noise. Sometimes it adds value. It'd probably be better to get the feedback on your local machine instead of making the PR comments a mess. |
|
🎉 This PR is included in version 4.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request adds a GitHub Workflow similar to the Azure DevOps Pipeline.