-
Notifications
You must be signed in to change notification settings - Fork 57
fix(e2e): Add cleanup trap to prevent false positives in CI test runs #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
+ Coverage 77.39% 77.54% +0.14%
==========================================
Files 44 44
Lines 2823 2823
==========================================
+ Hits 2185 2189 +4
+ Misses 529 526 -3
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The e2e test script was storing the Ginkgo exit code but could still exit unexpectedly before cleanup, causing CI to mark incomplete test runs as successful (false positives). Signed-off-by: Francisco Herrera <[email protected]>
TEMPORARY FAILURE: check failure test on CI Signed-off-by: Francisco Herrera <[email protected]>
Fix lint messages Signed-off-by: Francisco Herrera <[email protected]>
This reverts commit 5346be9. Signed-off-by: Francisco Herrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* upstream/main: fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
* upstream/main: Enhance Documentation: convert markdown file to AsciiDocs (istio-ecosystem#1118) fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1227)
|
In response to a cherrypick label: new pull request created: #1232 |
The e2e test script was storing the Ginkgo exit code but could still exit unexpectedly before cleanup, causing CI to mark incomplete test runs as successful (false positives).
What type of PR is this?
What this PR does / why we need it:
Problem:
The e2e test script was storing the Ginkgo exit code, but could still exit unexpectedly before cleanup, causing CI to mark incomplete test runs as successful (false positives).
Solution:
cleanup()function withtrap cleanup EXIT INT TERMto ensure uninstall always runsResult:
Which issue(s) this PR fixes:
Fixes #1226
Related Issue/PR #
Additional information: