Refactor logs gather flow to support multiple clusters #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 75.73% 75.61% -0.13%
==========================================
Files 35 35
Lines 2061 2079 +18
==========================================
+ Hits 1561 1572 +11
- Misses 428 433 +5
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. |
- Refactor logs gathering flow to support logs gather from multiple clusters. This is used in multi cluster scenario - Add "getSecret" function to fetch certs that are used in multicluster test. - Add name cluster to be specified during log gathering. Signed-off-by: Maxim Babushkin <[email protected]>
MaxBab
force-pushed
the
refactor_logs_gathering_flow
branch
from
953cb16 to
c52d103
Compare
dgn
approved these changes
Oct 28, 2024
sridhargaddam
approved these changes
Oct 28, 2024
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 28, 2024
* upstream/main: Consolidate reconciler config fields into ReconcilerConfig (istio-ecosystem#453) Refactor logs gather flow to support multiple clusters (istio-ecosystem#452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #422