Use gcr.io for Istio images and quay.io/sail-dev for sample applications

[luksa]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (a7a5ceb) to head (1ab5729).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   74.43%   74.03%   -0.40%     
==========================================
  Files          40       40              
  Lines        2511     2511              
==========================================
- Hits         1869     1859      -10     
- Misses        554      561       +7     
- Partials       88       91       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sridhargaddam]

Thanks @luksa

[luksa]

@sridhargaddam I guess I also need to move sleep/httpbin in the same PR.

[sridhargaddam]

@sridhargaddam I guess I also need to move sleep/httpbin in the same PR.

We seem to be using the following images and they may not be present on the gcr.io

	envVarMap := map[string]string{
		"tcp-echo-dual-stack": "TCP_ECHO_DUAL_STACK_YAML_PATH",
		"tcp-echo-ipv4":       "TCP_ECHO_IPV4_YAML_PATH",
		"tcp-echo":            "TCP_ECHO_IPV4_YAML_PATH",
		"tcp-echo-ipv6":       "TCP_ECHO_IPV6_YAML_PATH",
		"sleep":               "SLEEP_YAML_PATH",
		"helloworld":          "HELLOWORLD_YAML_PATH",
		"sample":              "HELLOWORLD_YAML_PATH",
		"httpbin":             "HTTPBIN_YAML_PATH",
	}

[istio-testing]

In response to a cherrypick label: #613 failed to apply on top of branch "release-1.0":

Applying: Use gcr.io for Istio images
Using index info to reconstruct a base tree...
M	bundle/manifests/sailoperator.clusterserviceversion.yaml
A	resources/v1.21.6/charts/cni/values.yaml
A	resources/v1.21.6/charts/istiod/values.yaml
A	resources/v1.21.6/charts/revisiontags/values.yaml
A	resources/v1.21.6/charts/ztunnel/values.yaml
A	resources/v1.22.5/charts/cni/values.yaml
A	resources/v1.22.5/charts/istiod/values.yaml
A	resources/v1.22.5/charts/revisiontags/values.yaml
A	resources/v1.22.5/charts/ztunnel/values.yaml
A	resources/v1.22.6/charts/cni/values.yaml
A	resources/v1.22.6/charts/istiod/values.yaml
A	resources/v1.22.6/charts/revisiontags/values.yaml
A	resources/v1.22.6/charts/ztunnel/values.yaml
A	resources/v1.22.7/charts/cni/values.yaml
A	resources/v1.22.7/charts/istiod/values.yaml
A	resources/v1.22.7/charts/revisiontags/values.yaml
A	resources/v1.22.7/charts/ztunnel/values.yaml
A	resources/v1.22.8/charts/cni/values.yaml
A	resources/v1.22.8/charts/istiod/values.yaml
A	resources/v1.22.8/charts/revisiontags/values.yaml
A	resources/v1.22.8/charts/ztunnel/values.yaml
A	resources/v1.23.2/charts/cni/values.yaml
A	resources/v1.23.2/charts/istiod-remote/values.yaml
A	resources/v1.23.2/charts/istiod/values.yaml
A	resources/v1.23.2/charts/revisiontags/values.yaml
A	resources/v1.23.2/charts/ztunnel/values.yaml
A	resources/v1.24.0/charts/cni/values.yaml
A	resources/v1.24.0/charts/istiod/values.yaml
A	resources/v1.24.0/charts/revisiontags/values.yaml
A	resources/v1.24.0/charts/ztunnel/values.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): resources/v1.24.0/charts/ztunnel/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.24.0/charts/ztunnel/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.24.0/charts/revisiontags/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.24.0/charts/revisiontags/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.24.0/charts/istiod/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.24.0/charts/istiod/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.24.0/charts/cni/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.24.0/charts/cni/values.yaml left in tree.
Auto-merging resources/v1.23.0/charts/ztunnel/values.yaml
Auto-merging resources/v1.23.0/charts/revisiontags/values.yaml
Auto-merging resources/v1.23.0/charts/istiod/values.yaml
Auto-merging resources/v1.23.0/charts/istiod-remote/values.yaml
Auto-merging resources/v1.23.0/charts/cni/values.yaml
CONFLICT (modify/delete): resources/v1.22.8/charts/ztunnel/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.8/charts/ztunnel/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.8/charts/revisiontags/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.8/charts/revisiontags/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.8/charts/istiod/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.8/charts/istiod/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.8/charts/cni/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.8/charts/cni/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.7/charts/ztunnel/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.7/charts/ztunnel/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.7/charts/revisiontags/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.7/charts/revisiontags/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.7/charts/istiod/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.7/charts/istiod/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.7/charts/cni/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.7/charts/cni/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.6/charts/ztunnel/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.6/charts/ztunnel/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.6/charts/revisiontags/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.6/charts/revisiontags/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.6/charts/istiod/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.6/charts/istiod/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.6/charts/cni/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.6/charts/cni/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.5/charts/ztunnel/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.5/charts/ztunnel/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.5/charts/revisiontags/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.5/charts/revisiontags/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.5/charts/istiod/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.5/charts/istiod/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.22.5/charts/cni/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.22.5/charts/cni/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.21.6/charts/ztunnel/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.21.6/charts/ztunnel/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.21.6/charts/revisiontags/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.21.6/charts/revisiontags/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.21.6/charts/istiod/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.21.6/charts/istiod/values.yaml left in tree.
CONFLICT (modify/delete): resources/v1.21.6/charts/cni/values.yaml deleted in HEAD and modified in Use gcr.io for Istio images. Version Use gcr.io for Istio images of resources/v1.21.6/charts/cni/values.yaml left in tree.
Auto-merging bundle/manifests/sailoperator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/sailoperator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Use gcr.io for Istio images

[istio-testing]

In response to a cherrypick label: new issue created for failed cherrypick: #614